Skip to content

chore: remove replay authority override#1320

Merged
thlorenz merged 2 commits into
masterfrom
thlorenz/rm-val-override-replay
Jun 15, 2026
Merged

chore: remove replay authority override#1320
thlorenz merged 2 commits into
masterfrom
thlorenz/rm-val-override-replay

Conversation

@thlorenz

@thlorenz thlorenz commented Jun 14, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

Summary

Remove the unused ledger replay validator-authority override feature.

Details

Configuration

Removes ledger.replay-authority-override from LedgerConfig and the example config. This also removes the corresponding environment variable support for MBV_LEDGER__REPLAY_AUTHORITY_OVERRIDE through normal config deserialization.

The replica-mode authority override remains supported via validator.replication-mode.replica.authority-override.

Ledger restore tests

Removes integration test helpers and duplicate restore test variants that existed only to exercise the replay override path. The remaining ledger restore tests now use the standard validator setup paths.

Summary by CodeRabbit

Release Notes

  • Chores
    • Removed the optional validator authority override setting used during ledger replay.
    • Updated ledger restore and replay tests/utilities to stop accepting or using authority override inputs, and to consistently use standard validator initialization.
    • Adjusted related helper signatures and test assertions to match the simplified restore/replay workflow.

@coderabbitai

coderabbitai Bot commented Jun 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 55f894b6-051c-464f-98e1-dd507fe7f764

📥 Commits

Reviewing files that changed from the base of the PR and between 649669d and d8b911f.

📒 Files selected for processing (2)
  • test-integration/test-ledger-restore/tests/04_flexi_counter.rs
  • test-integration/test-ledger-restore/tests/09_restore_different_accounts_multiple_times.rs
📝 Walkthrough

Walkthrough

This PR removes the replay_authority_override feature entirely. The replay_authority_override: Option<SerdePubkey> field is deleted from the LedgerConfig struct along with its Default initialization, the SerdePubkey import is dropped, and the corresponding MBV_LEDGER__REPLAY_AUTHORITY_OVERRIDE documentation is removed from config.example.toml. Two exported test helper functions (setup_offline_validator_with_authority_override and setup_validator_with_local_remote_and_authority_override) are removed from the integration test library. All four ledger-restore integration test files are updated to drop the authority_override parameter from their local read/read_ledger helpers, remove the conditional branching that selected the override setup path, and remove now-unused imports.

Suggested reviewers

  • bmuddha
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch thlorenz/rm-val-override-replay

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@thlorenz thlorenz marked this pull request as ready for review June 14, 2026 05:34
bmuddha
bmuddha approved these changes Jun 15, 2026
View reviewed changes

@bmuddha bmuddha left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thlorenz thlorenz merged commit 34480c1 into master Jun 15, 2026
71 checks passed
@thlorenz thlorenz deleted the thlorenz/rm-val-override-replay branch June 15, 2026 09:45
thlorenz added a commit that referenced this pull request Jun 16, 2026
@thlorenz
Merge branch 'master' into thlorenz/ai-agents-spec
5aa361d 
* master:
  fix(replicator): drain the replication stream (#1325)
  fix(accountsdb): allow for accountsdb to be shrunk (#1326)
  chore: remove replay authority override (#1320)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bmuddha bmuddha bmuddha approved these changes

@GabrielePicco GabrielePicco Awaiting requested review from GabrielePicco

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thlorenz @bmuddha